[SofaHelper] Factory key type can be other than std::string #2259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factories were used only with
std::string
as a key. That is why it was not noticeable that factories were not compatible with other types thanstd::string
as the key.The limitations come from:
logFactoryRegister
assumedKey
is a string. It is now a template function.Creator
inherits fromKey
and instances was used such as it was a string. Now,Creator
no longer inherits fromKey
but just stores the key as a class member.A unit test is added for enum type as a key.
Small downside:
std::string& getFactoryLog()
is now available outside the translation unit.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if